search

nathantannar4 / Transmission

Bridges UIKit presentation APIs to a SwiftUI API so you can use presentation controllers, interactive transitions and more.
BSD 2-Clause "Simplified" License
378 stars 13 forks source link

Make sure window presentation has no background #30

Closed danqing closed 6 months ago

danqing commented 8 months ago

Right now the window is opaque + the root view has the system background. This is a regression from before 1.1 — I'm not exactly sure what broke it.

This is affecting our toasts, which use something like:

content
    .window(
        level: .overlay,
        transition: .move(edge: .top).combined(with: .opacity),
        isPresented: $toastCoordinator.toast.isNotNil()
    ) { ... }

The .window is opaque and covers the whole screen.

danqing commented 8 months ago

Btw @nathantannar4 the current version of transmission requires engine 1.4+ but looks like you haven't tagged it there; not sure if that's intentional or not.

vpontis commented 8 months ago

Btw @nathantannar4 the current version of transmission requires engine 1.4+ but looks like you haven't tagged it there; not sure if that's intentional or not.

@danqing related to #28

nathantannar4 commented 6 months ago

@danqing Reported in #29 and fixed in 1.1.2