[BUG] max() iterable argument is empty

Describe the bug

The download of my playlist went fine but about 80 tracks in streamrip crashed with this value error.

Command Used

rip url https://www.deezer.com/en/playlist/[redacted]

Debug Traceback

╭─────────────────────────────── Traceback (most recent call last) ────────────────────────────────╮
│ in _run_module_as_main:198                                                                       │
│ in _run_code:88                                                                                  │
│                                                                                                  │
│                                     ... 17 frames hidden ...                                     │
│                                                                                                  │
│ C:\Users\[redacted]\AppData\Local\Programs\Python\Python312\Lib\site-packages\streamrip\client\dee │
│ zer.py:191 in get_downloadable                                                                   │
│                                                                                                  │
│   188 │   │                                                                                      │
│   189 │   │   dl_info["url"] = url                                                               │
│   190 │   │   logger.debug("dz track info: %s", track_info)                                      │
│ ❱ 191 │   │   return DeezerDownloadable(self.session, dl_info)                                   │
│   192 │                                                                                          │
│   193 │   def _get_encrypted_file_url(                                                           │
│   194 │   │   self,                                                                              │
│                                                                                                  │
│ C:\Users\[redacted]\AppData\Local\Programs\Python\Python312\Lib\site-packages\streamrip\client\dow │
│ nloadable.py:92 in __init__                                                                      │
│                                                                                                  │
│    89 │   │   logger.debug("Deezer info for downloadable: %s", info)                             │
│    90 │   │   self.session = session                                                             │
│    91 │   │   self.url = info["url"]                                                             │
│ ❱  92 │   │   max_quality_available = max(                                                       │
│    93 │   │   │   i for i, size in enumerate(info["quality_to_size"]) if size > 0                │
│    94 │   │   )                                                                                  │
│    95 │   │   self.quality = min(info["quality"], max_quality_available)                         │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯
ValueError: max() iterable argument is empty
sys:1: RuntimeWarning: coroutine 'Playlist.download.<locals>._resolve_download' was never awaited

Config File

[downloads]
# Folder where tracks are downloaded to
folder = "C:\\Users\\[redacted]\\StreamripDownloads"
# Put Qobuz albums in a 'Qobuz' folder, Tidal albums in 'Tidal' etc.
source_subdirectories = false

# Download (and convert) tracks all at once, instead of sequentially. 
# If you are converting the tracks, or have fast internet, this will 
# substantially improve processing speed.
concurrency = true
# The maximum number of tracks to download at once
# If you have very fast internet, you will benefit from a higher value,
# A value that is too high for your bandwidth may cause slowdowns
# Set to -1 for no limit
max_connections = 6
# Max number of API requests per source to handle per minute
# Set to -1 for no limit
requests_per_minute = 60

[qobuz]
# 1: 320kbps MP3, 2: 16/44.1, 3: 24/<=96, 4: 24/>=96
quality = 3
# This will download booklet pdfs that are included with some albums
download_booklets = true

# Authenticate to Qobuz using auth token? Value can be true/false only
use_auth_token = false
# Enter your userid if the above use_auth_token is set to true, else enter your email
email_or_userid = ""
# Enter your auth token if the above use_auth_token is set to true, else enter the md5 hash of your plaintext password
password_or_token = ""
# Do not change
app_id = ""
# Do not change
secrets = []

[tidal]
# 0: 256kbps AAC, 1: 320kbps AAC, 2: 16/44.1 "HiFi" FLAC, 3: 24/44.1 "MQA" FLAC
quality = 3
# This will download videos included in Video Albums.
download_videos = true

# Do not change any of the fields below
user_id = ""
country_code = ""
access_token = ""
refresh_token = ""
# Tokens last 1 week after refresh. This is the Unix timestamp of the expiration
# time. If you haven't used streamrip in more than a week, you may have to log
# in again using `rip config --tidal`
token_expiry = ""

[deezer]
# 0, 1, or 2
# This only applies to paid Deezer subscriptions. Those using deezloader
# are automatically limited to quality = 1
quality = 2
# An authentication cookie that allows streamrip to use your Deezer account
# See https://github.com/nathom/streamrip/wiki/Finding-Your-Deezer-ARL-Cookie
# for instructions on how to find this
arl = "[redacted]"
# This allows for free 320kbps MP3 downloads from Deezer
# If an arl is provided, deezloader is never used
use_deezloader = true
# This warns you when the paid deezer account is not logged in and rip falls
# back to deezloader, which is unreliable
deezloader_warnings = true

[soundcloud]
# Only 0 is available for now
quality = 0
# This changes periodically, so it needs to be updated
client_id = ""
app_version = ""

[youtube]
# Only 0 is available for now
quality = 0
# Download the video along with the audio
download_videos = false
# The path to download the videos to
video_downloads_folder = "C:\\Users\\[redacted]\\StreamripDownloads\\YouTubeVideos"

[database]
# Create a database that contains all the track IDs downloaded so far
# Any time a track logged in the database is requested, it is skipped
# This can be disabled temporarily with the --no-db flag
downloads_enabled = true
# Path to the downloads database 
downloads_path = "C:\\Users\\[redacted]\\AppData\\Roaming\\streamrip\\downloads.db"
# If a download fails, the item ID is stored here. Then, `rip repair` can be
# called to retry the downloads
failed_downloads_enabled = true
failed_downloads_path = "C:\\Users\\[redacted]\\AppData\\Roaming\\streamrip\\failed_downloads.db"

# Convert tracks to a codec after downloading them.
[conversion]
enabled = false
# FLAC, ALAC, OPUS, MP3, VORBIS, or AAC
codec = "ALAC"
# In Hz. Tracks are downsampled if their sampling rate is greater than this. 
# Value of 48000 is recommended to maximize quality and minimize space
sampling_rate = 48000
# Only 16 and 24 are available. It is only applied when the bit depth is higher
# than this value.
bit_depth = 24
# Only applicable for lossy codecs
lossy_bitrate = 320

# Filter a Qobuz artist's discography. Set to 'true' to turn on a filter.
# This will also be applied to other sources, but is not guaranteed to work correctly
[qobuz_filters]
# Remove Collectors Editions, live recordings, etc.
extras = false
# Picks the highest quality out of albums with identical titles.
repeats = false
# Remove EPs and Singles
non_albums = false
# Remove albums whose artist is not the one requested
features = false
# Skip non studio albums
non_studio_albums = false
# Only download remastered albums
non_remaster = false

[artwork]
# Write the image to the audio file
embed = true
# The size of the artwork to embed. Options: thumbnail, small, large, original.
# "original" images can be up to 30MB, and may fail embedding. 
# Using "large" is recommended.
embed_size = "large"
# If this is set to a value > 0, max(width, height) of the embedded art will be set to this value in pixels
# Proportions of the image will remain the same
embed_max_width = -1
# Save the cover image at the highest quality as a seperate jpg file
save_artwork = true
# If this is set to a value > 0, max(width, height) of the saved art will be set to this value in pixels
# Proportions of the image will remain the same
saved_max_width = -1

[metadata]
# Sets the value of the 'ALBUM' field in the metadata to the playlist's name. 
# This is useful if your music library software organizes tracks based on album name.
set_playlist_to_album = true
# If part of a playlist, sets the `tracknumber` field in the metadata to the track's 
# position in the playlist instead of its position in its album
renumber_playlist_tracks = true
# The following metadata tags won't be applied
# See https://github.com/nathom/streamrip/wiki/Metadata-Tag-Names for more info
exclude = []

# Changes the folder and file names generated by streamrip.
[filepaths]
# Create folders for single tracks within the downloads directory using the folder_format
# template
add_singles_to_folder = false
# Available keys: "albumartist", "title", "year", "bit_depth", "sampling_rate",
# "id", and "albumcomposer"
folder_format = "{albumartist} - {title} ({year}) [{container}] [{bit_depth}B-{sampling_rate}kHz]"
# Available keys: "tracknumber", "artist", "albumartist", "composer", "title",
# and "albumcomposer", "explicit"
track_format = "{tracknumber:02}. {artist} - {title}{explicit}"
# Only allow printable ASCII characters in filenames.
restrict_characters = false
# Truncate the filename if it is greater than this number of characters
# Setting this to false may cause downloads to fail on some systems
truncate_to = 120

# Last.fm playlists are downloaded by searching for the titles of the tracks
[lastfm]
# The source on which to search for the tracks.
source = "qobuz"
# If no results were found with the primary source, the item is searched for 
# on this one.
fallback_source = ""

[cli]
# Print "Downloading {Album name}" etc. to screen
text_output = true
# Show resolve, download progress bars
progress_bars = true
# The maximum number of search results to show in the interactive menu
max_search_results = 100

[misc]
# Metadata to identify this config file. Do not change.
version = "2.0.3"
# Print a message if a new version of streamrip is available 
check_for_updates = true

Operating System

Windows 11

streamrip version

2.0.5

Screenshots and recordings

No response

Additional context

No response

Adding --quality=2 seems to work as a workaround.

Ignore my previous comment, I'm getting it too.

max_quality_available = max( (i for i, size in enumerate(info["quality_to_size"]) if size > 0), default=0 )

Am running the project locally, the above does not appear to be a solution (it did not halt propagation and it ended up failing further along) but my python sucks to the point where I can't get a debugger running.

A debug log would help better. And possibly a playlist link if it's public, or better the concrete track that is failing. Does it happen with any playlist/album?

The above commit solved the bug for me, however, if you get a File Not Found and/or Mutagen Error instead after the script tries to remove the temporary artwork files; this is fixable by disabling artwork from being embedded in the config file

Example error traceback:

           DEBUG    Removing dirs {'C:\\Users\\TimBr\\StreamripDownloads\\Glow Weird Wubs\\__artwork'}                                                                                                                  artwork.py:19
┌─────────────────────────────── Traceback (most recent call last) ────────────────────────────────┐
│ C:\Users\TimBr\Music Curation\streamrip_dev\.venv\Lib\site-packages\mutagen\_util.py:251 in      │
│ _openfile                                                                                        │
│                                                                                                  │
│    248 │   │                                                                                     │
│    249 │   │   inmemory_fileobj = False                                                          │
│    250 │   │   try:                                                                              │
│ >  251 │   │   │   fileobj = open(filename, "rb+" if writable else "rb")                         │
│    252 │   │   except IOError as e:                                                              │
│    253 │   │   │   if writable and e.errno == errno.EOPNOTSUPP:                                  │
│    254 │   │   │   │   # Some file systems (gvfs over fuse) don't support opening                │
│                                                                                                  │
│ ┌─────────────────────────────────────────── locals ───────────────────────────────────────────┐ │
│ │           create = False                                                                     │ │
│ │         filename = 'C:\\Users\\TimBr\\StreamripDownloads\\Glow Weird Wubs\\09. Flume -       │ │
│ │                    Spring.mp3'                                                               │ │
│ │          fileobj = None                                                                      │ │
│ │        filething = 'C:\\Users\\TimBr\\StreamripDownloads\\Glow Weird Wubs\\09. Flume -       │ │
│ │                    Spring.mp3'                                                               │ │
│ │ inmemory_fileobj = False                                                                     │ │
│ │         instance = {}                                                                        │ │
│ │         writable = False                                                                     │ │
│ └──────────────────────────────────────────────────────────────────────────────────────────────┘ │
└──────────────────────────────────────────────────────────────────────────────────────────────────┘
FileNotFoundError: [Errno 2] No such file or directory: 'C:\\Users\\TimBr\\StreamripDownloads\\Glow Weird Wubs\\09. Flume - Spring.mp3'

See the commit comments for a more detailed version of this comment

I think you should open a new issue with that, will be more organized

Good point, unfortunately that work around doesn't work properly anyhow. I had not fixed an issue similar to #537 yet so my config file wasn't properly called upon

Regarding the PR #683. Just accidentaly found a broken track for this use case, as it wasn't provided in this issue, rip url https://www.deezer.com/track/526311152 And the error is captured but I see the stacktrace at the end which is not a good thing I think. Just 1 line error would be better, something is missing when capturing that NonStreamableError.

Cannot test it with other tracks after that one, but I'm pretty sure the execution would crash before downloading other tracks.

⠸ Resolving URLs...[21:34:55] ERROR    Error fetching album of track 526311152: DataException: album/68014722 no data
      deezer.py:80
┌─────────────────────────────── Traceback (most recent call last) ────────────────────────────────┐
│ in _run_module_as_main:198                                                                       │
│ in _run_code:88                                                                                  │
│                                                                                                  │
│                                     ... 14 frames hidden ...                                     │
│                                                                                                  │
│ d:\01\q\venv\Lib\site-packages\streamrip\client\deezer.py:191 in get_downloadable                │
│                                                                                                  │
│   188 │   │                                                                                      │
│   189 │   │   dl_info["url"] = url                                                               │
│   190 │   │   logger.debug("dz track info: %s", track_info)                                      │
│ > 191 │   │   return DeezerDownloadable(self.session, dl_info)                                   │
│   192 │                                                                                          │
│   193 │   def _get_encrypted_file_url(                                                           │
│   194 │   │   self,                                                                              │
│                                                                                                  │
│ d:\01\q\venv\Lib\site-packages\streamrip\client\downloadable.py:131 in __init__                  │
│                                                                                                  │
│   128 │   │   │   i for i, size in enumerate(info["quality_to_size"]) if size > 0                │
│   129 │   │   ]                                                                                  │
│   130 │   │   if len(qualities_available) == 0:                                                  │
│ > 131 │   │   │   raise NonStreamableError(                                                      │
│   132 │   │   │   │   "Missing download info. Skipping.",                                        │
│   133 │   │   │   )                                                                              │
│   134 │   │   max_quality_available = max(qualities_available)                                   │
└──────────────────────────────────────────────────────────────────────────────────────────────────┘
NonStreamableError: Missing download info. Skipping.

I hope this finds someone well. I did happen to uncover some of the issues leading up to this main issue. I have done a rather hacky fix based on stuff I found.

I noticed some errors preceding this error in the output like this:

ERROR Error fetching album of track 499218282: DataException: album/63443292/tracks no data deezer.py:80

So I followed the part album/63443292 to the url https://www.deezer.com/us/album/63443292. I noticed deezer redirects to the same album but with a different ID.
So I figured this was probably a result of this deezer/spotify playlist converter I used.
Anyway, from the newly redirected album I added back the tracks that were in my playlist and removed the ones originally created in my playlist.
This effectively removes the tracks related to the albums getting redirected in deezer from my playlist.
I re-ran the download and it continues successfully.
When I hit more of the same errors simply rinse and repeat this fix.

Nice one, Corey.

That looks like really in depth look at what is happening.

My workaround to this has actually been to remove and then re-add the offending tracks to the playlist on Deezer. It's a bit of a hassle for massive playlists but it's straightforward enough.

On Fri, 20 Sept 2024 at 09:21, Corey Berigan @.***> wrote:

I hope this finds someone well. I did happen to uncover some of the issues leading up to this main issue. I have done a rather hacky fix based on stuff I found.

I noticed some errors preceding this error in the output like this:

ERROR Error fetching album of track 499218282: DataException: album/63443292/tracks no data deezer.py:80

So I followed the part album/63443292 to the url https://www.deezer.com/us/album/63443292. I noticed deezer redirects to the same album but with a different ID.

So I figured this was probably a result of this deezer/spotify playlist converter I used.

Anyway, from the newly redirected album I added back the tracks that were in my playlist and removed the ones originally created in my playlist.

This effectively removes the tracks related to the albums getting redirected in deezer from my playlist.

I re-ran the download and it continues successfully.

When I hit more of the same errors just keep apply this fix until it completes

— Reply to this email directly, view it on GitHub https://github.com/nathom/streamrip/issues/677#issuecomment-2363005910, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGX5JKBL3M2PZYQKGRXYPLZXPEGPAVCNFSM6AAAAABHOJI5Q2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRTGAYDKOJRGA . You are receiving this because you commented.Message ID: @.***>

nathom / streamrip