search

nativescript-community / ui-material-components

Monorepo that contains all of the NativeScript Material Design plugins.
https://nativescript-community.github.io/ui-material-components/
Apache License 2.0
219 stars 80 forks source link

[bottomsheet] The bottom sheet doesn't work after upgrading to Angular 12 #307

Closed Bezlepkin closed 3 years ago

Bezlepkin commented 3 years ago

After updating to Angular 12 bottomsheet throws an error.

ERROR Error: Uncaught (in promise): TypeError: Right-hand side of 'instanceof' is not an object

I looked into the code and saw that there is no AppHostView in Angular 12 2021-06-09_14-13-33

edusperoni commented 3 years ago

This is fixed in: https://github.com/NativeScript/angular/commit/601b080de38eff91b5e40aed44fbb9782d08c05a

Hugo-Dlg commented 3 years ago

Is it a client side modification or dev side ?

Bezlepkin commented 3 years ago

Is it a client side modification or dev side ?

What you mean?

Hugo-Dlg commented 3 years ago

I was wondering if we had to do the modification as a user in our program or if it had to be done by the package developer, but I found the answer after thinking about it

Bezlepkin commented 3 years ago

I was wondering if we had to do the modification as a user in our program or if it had to be done by the package developer, but I found the answer after thinking about it

I made a package in node_modules but nothing has changed. Apparently we need to wait for @nativescript/angular 12.0.2

edusperoni commented 3 years ago

@nativescript/angular@12.0.2 has been released today. Please update and test it! I think this issue can be closed

Bezlepkin commented 3 years ago

I get new error:

JS: ERROR TypeError: Cannot read property '0' of null

I checked the code, I suspect that an error occurs when calling this method: 2021-06-18_09-37-34

farfromrefug commented 3 years ago

@Bezlepkin @edusperoni cant say much about angular. Would need some help to fix this.