search

nativescript-community / ui-material-components

Monorepo that contains all of the NativeScript Material Design plugins.
https://nativescript-community.github.io/ui-material-components/
Apache License 2.0
219 stars 80 forks source link

Bottom navigation bar - Router Outlet #323

Closed csimpi closed 3 years ago

csimpi commented 3 years ago

I have the most recent version of everything.

Unfortunately, it seems the demo doesn't compatible with page-router-outlet. The demo uses ngSwitch to switch between tabs. It seems ngSwitch doesn't work with page-router-outlet. When I change a tab and change back the content disappears. I guess this is by Angular. I remember there're similar issues with ngIf before.

Based on these I think there are two ways to handle this:

farfromrefug commented 3 years ago

@csimpi dont know much about angular. You are welcome to make a PR

csimpi commented 3 years ago

@farfromrefug Are you kidding? As I know this supposed to be the "official" NS UI plugin as a replacement the deprecated core elements and you are just ignoring Angular? Also your answers seems to be rude, like you are angry because I asked about Angular. Angular is an essential part of NS and as I see on the channel it is going to be more and more popular.

Please, support Angular or don't say this is going to be the replacement of the core UI elements. I upgraded to NS8 but it seems NOTHING is supported, the whole project is collapsing

farfromrefug commented 3 years ago

@csimpi where did you see it was an official N plugin :D well, what wait... am i paid for this?

Thank you for you kindness. have a great day

csimpi commented 3 years ago

@farfromrefug You are super rude man, this is not a community plugin, it seems you are the only one here, and nobody participate anymore. I guess why, cause I wanted to contribute if necessary but not anymore. Your communication skills are super low.

Here is your answer, from NativeScript Blog, the official announcement of version 8: https://blog.nativescript.org/nativescript-8-announcement/#important-note-about-bottomnavigation-and-tabs

Important note about BottomNavigation and Tabs BottomNavigation and Tabs ui components in core brought along Cocoapods whether your project used them or not. With 8.0, they now are provided by the community where ### they can receive more focused attention not bound or held up by NativeScript core updates.

farfromrefug commented 3 years ago

@csimpi stop saying i am rude, read yourself! I agreed to took over those components from the N core project. And YES it IS a community project. I am mostly the only one here because i created that repo from the start and did it all. There is no one else mostly because everyone is like you, simply ungrateful for what other do for you out of kindness and trust for OSS. I am done talking here. If you are unhappy move your "rude" discussions on discord

csimpi commented 3 years ago

@farfromrefug Repeating OSS project won't justify that, BottomNavigation worked perfectly before now you ruined it. Why did you even touch it if it worked well? Everybody with {N} + Angular upgrading to 8 is over? not supported? job is done? congrats then for your awesome COmMuNitY

vallemar commented 3 years ago

@csimpi I don't see what to say if you want to do a pr be rude. what if I see rude is your answer. If you know what needs to be fixed, why don't you do it yourself? this is not a rude answer, it is just my vision

csimpi commented 3 years ago

I was grown up that way when I start something and take responsibility then I handle it that way. This is like you start building houses for a community then left them unfinished and ask strangers to finish that you started. Fix the mistakes you have done.

After you've built a house well you can ask the community to make it better, for example, painting.

But this repo currently is like a house where one of the important pillars is missing, nobody wants to live there it's dangereous.

After all, sorry for being rude from my side, this is just my opinion. Everything around {N} is terribly maintained, the worst coding experience ever despite that I'm coming from the old days where everything was 10000x difficult.

vallemar commented 3 years ago

the code is NOT a house, when would the complement be finished? Could we say that when did it work for you? probably not. if it has been touched, it will have been due to other errors that you, due to your logic, did not receive or improvements. So, no one could ever come in to do anything. I do not have your point of view and I think you should try to have other points of view

csimpi commented 3 years ago

@vallemar tell these to people who work in NASA or working on software for robots for brain surgery ... when I do code I do it that way... like I build a house where people are going to live in. Another way I would feel I'm selfish and do coding for myself and for money.

I've seen every single point of view in my life you are talking about, I know what is real and what is behind a pink curtain... you'll learn this too eventually...

Tyler-V commented 3 years ago

Is this still an active issue??

juniorschen commented 3 years ago

Unfortunately nativescript/angukar is just a promise that turned into a pile of shit

farfromrefug commented 3 years ago

@juniorschen please such comment have no place on github. It is a place to report issues. Not to give opinions or swear ... I will hide your comment because of this.

Salahudeen commented 9 months ago

@csimpi @vallemar Were you able to find any resolution to this issue? if so, can you guide me on the same?

vallemar commented 9 months ago

@Salahudeen Could you make a sample repository with the problem? I think I could take a look but I don't really know what's going on

Salahudeen commented 9 months ago

@vallemar Thanks for the quick response. I made the below repo with the details. Please run on iOS https://github.com/Salahudeen/ui-material-bottomnavigationbar-issue

Objective is to lazy load modules on each tab load like in the example ns create my-app => Tab sample app.