search

nativescript-community / ui-material-components

Monorepo that contains all of the NativeScript Material Design plugins.
https://nativescript-community.github.io/ui-material-components/
Apache License 2.0
219 stars 80 forks source link

feat(BottomSheet): add default collapsed sheet height for android #330

Closed vallemar closed 3 years ago

vallemar commented 3 years ago

Related to https://github.com/nativescript-community/ui-material-components/issues/306

farfromrefug commented 3 years ago

@vallemar so the iOS counterpart is not working? Event with the setPee... method? Could you stil add the code to that PR so that i can look at it ?

vallemar commented 3 years ago

@farfromrefug I have added the code for ios, but it does nothing :( I think this is the line that is establishing the height: https://github.com/vallemar/ui-material-components/blob/master/src/bottomsheet/bottomsheet.ios.ts#L168

farfromrefug commented 3 years ago

@vallemar i released it for iOS/Android ! thanks for your PR