search

nats-io / nats-streaming-server

NATS Streaming System Server
https://nats.io
Apache License 2.0
2.51k stars 284 forks source link

nats is using a retracted dependency making use of the latest nats server impossible as a dependency for other projects #1284

Closed karlmutch closed 1 year ago

karlmutch commented 1 year ago

The most recent nats server is using a retracted version of the github.com/hashicorp/go-msgpack package (v1.1.5).

This makes using nats as a package dependency in other software impossible.


go: warning: github.com/hashicorp/go-msgpack@v1.1.5: retracted by module author: v1.1.5 merged upstream ugorji/go which breaks compatibility with previous versions.
go: to switch to the latest unretracted version, run:
        go get github.com/hashicorp/go-msgpack@latest
go: upgraded github.com/hashicorp/go-msgpack v0.5.5 => v1.1.5
go: upgraded github.com/nats-io/nats-streaming-server v0.18.0 => v0.25.3```

Unfortunately it is not possible to log an issue on the hashicorp fork for that project and the retracted package only has a major version after the retracted version.
kozlovic commented 1 year ago

@karlmutch I had made a change in PR #1285 and wonder if you had a chance to test/check that this addresses the issue? I could do a release v0.25.4 in a short turn around if need be.