Basic implementation and test for connection threshold

natverse / neuprintr

R client utilities for interacting with the neuPrint connectome analysis service

http://natverse.org/neuprintr

3 stars 3 forks source link

Basic implementation and test for connection threshold #128

Closed jefferis closed 3 years ago

jefferis commented 3 years ago

note that checkmate was already an indirect dependency
@romainFr any comments? Also what do you think should happen when we have specified an ROI? Should the threshold apply to the total connectivity or to the ROI connectivity alone? Right now it is the former but I suspect it should be the latter ...

romainFr commented 3 years ago

Useful addition, thanks! I do agree that the filter should be on ROI weight -- we've been thresholding mostly on ROI weight in our analysis. Alternatively, one could have one threshold for the ROI and one threshold for the neuron?

jefferis commented 3 years ago

Useful addition, thanks! I do agree that the filter should be on ROI weight -- we've been thresholding mostly on ROI weight in our analysis.

OK.

Alternatively, one could have one threshold for the ROI and one threshold for the neuron?

I think I would probably keep it simple. Part of my motivation was just to avoid transferring a lot of n=1 or 2 connections. I think people can add secondary threshold criteria themselves if they want.