search

natverse / neuprintr

R client utilities for interacting with the neuPrint connectome analysis service
http://natverse.org/neuprintr
3 stars 3 forks source link

the "details" argument field in neuprint_connection_table doesn't work with character vector #173

Closed artxz closed 10 months ago

artxz commented 10 months ago

seems it hasn't been implemented:

https://github.com/natverse/neuprintr/blob/1bf392fb896710d64e1b03cdddb38ea05a54f5d1/R/connectivity.R#L302

jefferis commented 10 months ago

Hi @artxz, thanks for the report. Could you give an example? That line of code is actually fine (if details is a character vector then isTRUE(details) is FALSE and program execution continues):

> isTRUE(c("a", "b"))
[1] FALSE

But that doesn't mean there isn't another bug ...

artxz commented 10 months ago

Hi @jefferis , I did an update and it seems to be working fine now. For the record, previously, neuprint_connection_table(1807537598, details=c("name","type")) returns an error (sorry the linked line was incorrect):

Error in if (details) firstcols = c(firstcols, "name", "type") : 
  argument is not interpretable as logical
jefferis commented 10 months ago

ok great. the best bugs are the ones we already fixed! Thanks again for your input!