search

navapbc / template-infra

A template to set up foundational infrastructure for your application in AWS
Apache License 2.0
11 stars 2 forks source link

Update app service root module to terraform aws provider v5.35.0+ #724

Closed rocketnova closed 3 months ago

rocketnova commented 3 months ago

The app service root module is currently pinned:

https://github.com/navapbc/template-infra/blob/48c76567034b229c738730972ad35a467aa1e9f8/infra/app/service/main.tf#L47-L50

The latest version of the aws provider is currently 5.61.0.

To make a smoother experience for the forthcoming notifications PR, it would be nice for us to upgrade to at least 5.35.0, so that we can access the new aws_sesv2_email_identity_policy resource that was added in that version. Until we update, project admins will need to take a manual step in the AWS console or use the aws cli for sesv2 to complete email-based email identity verification.

rocketnova commented 3 months ago

Documenting another issue I'm running into because of the app/service root module current version pin: The data resource aws_sesv2_email_identity was introduced in v5.5.0.

We need this so projects that have notifications enabled can re-use an existing email identity in PRs and workspaces. Pinpoint disallows subsequent attempts to add an email address that you have already verified.

CleanShot 2024-08-13 at 16 40 40@2x