search

navcoin / navcoin-core

bitcoin-core 0.13 fork ported for NavCoin
MIT License
123 stars 92 forks source link

Derivation path #495

Open aguycalled opened 5 years ago

aguycalled commented 5 years ago

Currently navcoin core shares with bitcoin the derivation path used for the generation of new addresses (m/0'/0'), this should be changed to m/44'/130' while preserving backwards compatibility with old wallets.

mxaddict commented 5 years ago

@aguycalled we should add an issue over at NavPay as well, and Next?

We only have 3 wallets to update right?

NEXT uses core? So do we have anything to change on that end?

aguycalled commented 5 years ago

NEXT uses core, NavPay should see an issue opened too

mxaddict commented 5 years ago

NEXT uses core, NavPay should see an issue opened too

ACK

mxaddict commented 5 years ago

I think NavPay is easier as it's just changing the default on creation and the default on import

Then adding a note on import page.

mxaddict commented 5 years ago

I think NavPay is easier as it's just changing the default on creation and the default on import

Then adding a note on import page.

This statement was WRONG :+1:

alexeyneu commented 5 years ago

i do not see anything on this here: https://github.com/bitcoin/bips/blob/master/bip-0130.mediawiki
so you're talkin about m/44'/130'

alexeyneu commented 5 years ago

and i found this: https://github.com/navcoin/navcoin-core/blob/498e75f2b915bf5d8fccc10c1080ed68b478fceb/src/wallet/wallet.cpp#L119
so what is it you finally wanna?

aguycalled commented 5 years ago

you are right, updated issue description

alexeyneu commented 5 years ago

Currently navcoin core shares with bitcoin the derivation path used for the generation of new addresses (m/0'/0'), this should be changed to m/44'/130' while preserving backwards compatibility with old wallets.

it'll be 44'/130'/0'/0'/0'
in 44'/130'/0' all three lose its meanings

EDIT:
you can go with letter stuff

mxaddict commented 5 years ago

@alexeyneu What do you mean by "letter stuff"

mxaddict commented 5 years ago

@alexeyneu are you working on this? If so I can assign this issue to you.

alexeyneu commented 5 years ago

may be i'll do it , may be not the bad is that you'd to add mnemonic early . And now all this deriv path stuff goes straight to user coz no one knows what he'd used to export it.
say in mew during import you choose path used , but before that you did it on export . So how i see it is to add option to importmnemonic like -before17 .
on the other hand it's new stuff so is not being used by many.

mxaddict commented 5 years ago

Additional info: https://github.com/bitcoin/bips/blob/master/bip-0044.mediawiki https://github.com/satoshilabs/slips/blob/master/slip-0044.md