naver / android-imagecropview

android image crop library
Apache License 2.0
254 stars 55 forks source link

Problem with restoring cropPosition when bitmap is scrolled to edge #17

Closed onlyway closed 7 years ago

onlyway commented 8 years ago

When I want to restore bitmap somewhere centered everything is working fine, but when I'm trying to scroll max to top or bottom, after restoration I'm not exactrly at the same position. I have margin from top or from bottom. Is there any workaround for this?

onlyway commented 8 years ago

In sample app I see the same bug with edges

helloyako commented 7 years ago

@onlyway Yes, that is bug.. I'm so sorry. 😭

onlyway commented 7 years ago

Do you have any walk around for this?

helloyako commented 7 years ago

Not yet

onlyway commented 7 years ago

Ok thx, i've tried to solve this couple of Tomek but no success :)

helloyako commented 7 years ago

@onlyway How are you? :) I fixed this issue.

I will include this spec in v1.2.0. but it's not released. You can use 1.2.0-snapshot or develop branch source code.

snapshot version from maven

repositories {
    maven { url "https://oss.sonatype.org/content/repositories/snapshots" }
}
dependencies {
   compile 'com.naver.android.helloyako:imagecropview:1.2.0-SNAPSHOT'
}

check please

helloyako commented 7 years ago

resolved v1.2.0

onlyway commented 7 years ago

Thx ;) I'll check it later