naver / egjs-flicking

🎠 ♻️ Everyday 30 million people experience. It's reliable, flexible and extendable carousel.
https://naver.github.io/egjs-flicking/
MIT License
2.69k stars 129 forks source link

fix: Add check before update #868

Open ishmalez opened 1 week ago

ishmalez commented 1 week ago

Issue

Details

Sometimes when mounting and unmounting different instances of Flicking slider, variable this.slotDiffer is undefined, throwing an exception on beforeUpdate() execution. This fix is just to avoid the exception.

CLAassistant commented 1 week ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Ismael Martínez seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

RodrigoProjects commented 1 week ago

Thanks for the fix! Will this be in the next minor @malangfox ?