search

naver / egjs-view360

360 integrated viewing solution
https://naver.github.io/egjs-view360/
MIT License
501 stars 91 forks source link

Cubestrip coordinates slightly inaccurate #357

Closed webciter closed 3 years ago

webciter commented 3 years ago

Tested the EAC Format for cubemaps but the video has gaps in the join of the cube. Maybe it needs altering slightly.

WoodNeck commented 3 years ago

Hello, @webciter! naver github io_egjs-view360_examples_panoviewer_projection-type_youtube html

The above screenshot is captured in our demo, is that the same issue? I'll take a look at that.

webciter commented 3 years ago

yes that is the issue, i was thinking maybe the vertices should overlap, then maybe push the uvs back a little

WoodNeck commented 3 years ago

Okay, I'll check this issue. I'll leave a comment here after it's fixed :)

WoodNeck commented 3 years ago

@webciter We've just released v3.5.0 that fixes this issue. You can try setting cubemapConfig.trim option to remove those graphical glitches between texture tiles. I've also removed the above glitch in our demo :)

webciter commented 3 years ago

thanks works ok now.

stale[bot] commented 3 years ago

This issue/PR has been automatically marked as stale because it has not had any update (including commits, comments, labels, milestones, etc) for 30 days. It will be closed automatically if no further update occurs in 7 day. Thank you for your contributions!

한글 이 이슈/PR은 commits, comments, labels, milestones 등 30일간 활동이 없어 자동으로 stale 상태로 전환되었습니다. 이후 7일간 활동이 없다면 자동으로 닫힐 예정입니다. 프로젝트 개선에 기여해주셔서 감사합니다.