navorite / sessionic

A web extension to save, manage and restore sessions, windows and tabs.
GNU Affero General Public License v3.0
466 stars 17 forks source link

English as main language should be read only #79

Closed inson1 closed 9 months ago

inson1 commented 9 months ago

Describe the problem

.

Describe the proposed solution

.

Alternatives considered

.

Importance

nice to have

navorite commented 9 months ago

Done!

inson1 commented 9 months ago

@navorite translations cant be changed + why my edits moved to translated strings?

navorite commented 9 months ago

Can you check if it works now? Also check if English is still read-only?

I made English read-only and left others as is manually

inson1 commented 9 months ago

@navorite I still couldnt change translations, that are done. I cant sent the screenshots, because there is the new error.

inson1 commented 9 months ago

@navorite No readonly anywhere (better than before, but is still missing :/)

navorite commented 9 months ago

@navorite No readonly anywhere (better than before, but is still missing :/)

I don't understand what you mean

inson1 commented 9 months ago

@navorite

  1. I can edit source string - english - readonly is missing brave_LEtvw9uBPL
  2. But I can edit done translations

PS How did the error disappeared? 24 hours?

Please delete the suggestion, I cant. brave_dxnMSuivFT brave_iULPLI6Pya

navorite commented 9 months ago

@navorite

1. I can edit source string - english - readonly is missing
   ![brave_LEtvw9uBPL](https://user-images.githubusercontent.com/75314629/282766892-e8d9e0ac-774f-4c26-9928-e165e3b4efce.png)

2. But I can edit done translations

PS How did the error disappeared? 24 hours?

Please delete the suggestion, I cant. brave_dxnMSuivFT brave_iULPLI6Pya

Can you check again?

inson1 commented 9 months ago

@navorite Still no readonly in english (yes, I changed it back) brave_aYY68vHr8E

yes, suggestion is deleted :)

navorite commented 9 months ago

Oh, I forgot to disable the custom work-flow. I think it is now solved, can you confirm this?

inson1 commented 9 months ago

@navorite done :) How did the error disappeared? 24 hours? You didnt respond.

navorite commented 9 months ago

I fixed the merge conflict manually