navorite / sessionic

A web extension to save, manage and restore sessions, windows and tabs.
GNU Affero General Public License v3.0
466 stars 17 forks source link

If no session is deleted then say it. #86

Closed inson1 closed 9 months ago

inson1 commented 9 months ago

Describe the bug

Even if no session is deleted this popup still shows up. image brave_lib1gnkYwh

PS why it says removed and not deleted

Version

Sessionic 1.6.0

Browser

Brave 1.60.114 Chromium: 119.0.6045.124 (Official Build) (64-bit)

Operating System

Windows 10

Severity

None

navorite commented 9 months ago

Do you mean the keybinding? It's working as intended. Read the Keyboard Shortcuts section in the settings. It is stated clearly that it deletes the session not the window.

inson1 commented 9 months ago

@navorite okay sorry. Maybe in that case it should delete last seletected tab/window/section? And say if it didnt deleted something.

navorite commented 9 months ago

@navorite okay sorry. Maybe in that case it should delete last seletected tab/window/section? And say if it didnt deleted something.

There is no such thing as a selected tab/window at the moment and I don't intend to implement that anytime soon. I'm working on the extension in my free-time for free because I love contributing to open-source stuff. You can't depend on me to implement everything, perhaps you or someone else could pick that up and contribute.

inson1 commented 9 months ago

@navorite It looked like it is. And I said you should do something? I will help, yes.

navorite commented 9 months ago

Fixed in e30abaf