feat: add cloudflare accountId option to the generator schema - Githubissues

naxodev / oss

Open Source Software (OSS) projects by naxodev

https://naxo.dev

MIT License

19 stars 1 forks source link

feat: add cloudflare accountId option to the generator schema #14

Closed NachoVazquez closed 1 year ago

NachoVazquez commented 1 year ago

PR Checklist

Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The accountId is necessary for deploying the worker, and we are not providing an option to define it.

What is the new behavior?

We define the accountId on the schema, and if present we added the account_id to the wrangler.toml

Does this PR introduce a breaking change?

[ ] Yes
[x] No