search

nblockchain / fsx

FSX is the ideal tool for people that use F# for their scripting needs.
MIT License
14 stars 5 forks source link

Fsdk: remove RunSynchronously calls #21

Closed webwarrior-ws closed 1 year ago

webwarrior-ws commented 1 year ago

Removed all Async.RunSynchronously() calls from Fsdk.

knocte commented 1 year ago

@webwarrior-ws this is not enough, if I merge this PR alone, all scripts that make use of these APIs will break. I asked you to modify also the script files to use Async.RunSynchronously in them.

webwarrior-ws commented 1 year ago

this is not enough, if I merge this PR alone, all scripts that make use of these APIs will break. I asked you to modify also the script files to use Async.RunSynchronously in them.

No files in the solution were affected. But after your remark I also checked files not in solution and found 1 use of modified function. I changed that call to include Async.RunSynchronously.

knocte commented 1 year ago

Ok good work, can you also address this TODO as part of this PR (in a 2nd commit) please: https://github.com/nblockchain/fsx/blob/master/Fsdk/Network.fs#L42

knocte commented 1 year ago

@webwarrior-ws in the 1st commit some lines that you changed can be improved by removing unneeded parentheses, pls do

webwarrior-ws commented 1 year ago

@webwarrior-ws in the 1st commit some lines that you changed can be improved by removing unneeded parentheses, pls do

Done