nbody6ppgpu / Nbody6PPGPU-beijing

This is Nbody6++GPU, an N-body star cluster simulation code, maintained by Rainer Spurzem and team.
14 stars 16 forks source link

Fix argument mismatches outside of MPI #8

Closed scaedufax closed 2 years ago

scaedufax commented 2 years ago

commit b788933: ksint.f contains two subroutines. In the first one (KSINT) cputim is called (line 51) on tt1 with an IMPLICIT REAL*8 from common6.h. Later on in subroutine GW_DECISION cputim is called again (line 728) on a variable called ttgr, but this time without any IMPLICIT behavior. On some machines this leads to an argument mismatch, as their default behavior is REAL*4 instead of REAL*8 from the first subroutine.

commit bf2bc808: Remove IMINR from custom_output call (line 1245). In src/Main/custom_output.F IMINR is not an argument, but introduced in common6.h. To me it looks like IMINR once was given to custom_output as argument, but at some point it moved to common6.h. There is another call to custom_output in line 140 without the IMINR argument. Probably the other call in line 1245 was just forgotten.