search

nbuytaert1 / apex-select2

Select lists in Oracle APEX as they should be
https://apex.oracle.com/pls/apex/f?p=64237:20
GNU General Public License v2.0
56 stars 18 forks source link

Lazy-loading: small change suggestion for a big performance gain #86

Closed 77capr closed 7 years ago

77capr commented 7 years ago

I am looking up names in a 150'000 persons directory using lazy loading. My page load went from several seconds to instantaneous through this modification: Around line 78 of the 3.0 PL/SQL where it reads: l_lov := apex_plugin_util.get_data it reads all the data into memory even though in the lazy-load case it never uses it. So, move that call to line 122 inside the if l_lazy_loading is null and it will only be executed when needed. I only tested the change for my use case, but for me it made all the difference.

rimblas commented 7 years ago

Ah, very nice find!

farzadso commented 7 years ago

@77capr why don't you create a pull request for nick to merge?

77capr commented 7 years ago

@farzadso OK, created my first ever pull request, hope I did it right

farzadso commented 7 years ago

@77capr nice! checked it out. Let's see if Nick decides to merge it

onlygecko commented 7 years ago

@77capr : You answered the question I was going to ask with an implementation suggestion. Thanks. :-)

@nbuytaert1 : Can You estimate if and when the commit request will be merged and a new version will be released?

nbuytaert1 commented 7 years ago

@77capr: Thanks for the pull request. I'll try to merge it this evening.

@onlygecko: I'll release a new version of the plugin this weekend.

nbuytaert1 commented 7 years ago

@77capr: I merged your pull request. It will be released in version 3.1.0.

Thanks again for creating the pull request.

p3t3r commented 6 years ago

Is this code in the plugin plsql? I see the change in the source code, but looking at the source of the plugin in APEX, this change is not there. I'm having issues with performance although lazy loading is set to "Yes".