search

ncapdevi / FragNav

An Android library for managing multiple stacks of fragments
1.5k stars 220 forks source link

java.util.EmptyStackException on switchTab #154

Closed danpetre closed 6 years ago

danpetre commented 6 years ago

Using FragNavController with option createEager = false can cause java.util.EmptyStackException on switching tabs

On FragNavController.kt private fun switchTabInternal, line 281

var tag = fragment.tag ?: fragmentStacksTags[index].peek()

If createEager is used with false , fragmentStacksTags at index != 0 first time will be empty. Peek on empty Stack will cause java.util.EmptyStackException

fix: var tag = fragment.tag ?: if(fragmentStacksTags[index].empty()) null else fragmentStacksTags[index].peek()

mateherber commented 6 years ago

Thanks for reporting!

I've opened the #156 PR to fix that