nccgroup / Berserko

Burp Suite extension to perform Kerberos authentication
GNU Affero General Public License v3.0
104 stars 15 forks source link

Suggestion: create krb5.conf file by default #7

Open cnotin opened 4 years ago

cnotin commented 4 years ago

I'm using Berserko 1.2 with Burp 2020.5.1 on Windows After a fresh install of the extension I configured the "domain settings" but when I tried to "test domain settings" I had a warning about a missing krb5.conf file. I created it with the button but I didn't notice it at first. Would it be possible to create it automatically by default when there's none?

rtt-ncc commented 4 years ago

Hi - thanks for your comment. It's a good point but it doesn't feel quite right to me for Burp extensions to be creating files on the user's machine without asking them first (at least not in an area of the file system that isn't for Burp). I'll have a look and see if there is a location where it would be more reasonable to create this.

cnotin commented 4 years ago

Yes that's what I through afterwards... Or perhaps add a more explicit warning that says to use the available button to create it? (I didn't notice it at first..)

maaaaz commented 1 year ago

Or just provide, in a specific window, the content of the krb5.conf that the user should copy/paste afterwards if he wants.