search

nccgroup / sobelow

Security-focused static analysis for the Phoenix Framework
Apache License 2.0
1.66k stars 92 forks source link

Adds Credo (and associated enhancements) #132

Closed houllette closed 1 year ago

houllette commented 1 year ago

Adds Credo to Sobelow project and makes changes to get the codebase passing all credo checks.

Also addresses #69 and #68 in a simplistic manner as I added in missing moduledocs to fix credo findings.

houllette commented 1 year ago

Pausing here cause I need to deliberate how best to proceed on integrating credo; since it isn't supported in the earlier versions of Elixir but I'm unsure if the value add is enough to justify deprecating support for those versions just for credo checks

houllette commented 1 year ago

For historical context I did decide to remove support for two more versions of Elixir (1.5 and 1.6) - after some research into notable libraries and projects in the community, none of them had support going as far back as Sobelow did. Even with support still being at 1.7 it is the furthest back in minimum version support I've seen thus far.