search

nccgroup / sobelow

Security-focused static analysis for the Phoenix Framework
Apache License 2.0
1.66k stars 92 forks source link

Use trunc when idx is given as a float instead of an int #148

Closed realcorvus closed 8 months ago

realcorvus commented 8 months ago

Truncating the value of idx seems to fix the ranges issue - https://github.com/nccgroup/sobelow/issues/145

You could just add this to https://github.com/nccgroup/sobelow/pull/146

houllette commented 8 months ago

Nice fix and thanks for the PR, @realcorvus! I will pull changes into #146 and push it over the line to get the bug fixes out!

houllette commented 8 months ago

Closing this PR since I brought your changes over to the other PR 🙂