Closed iarekk closed 6 months ago
Potentially this fixes #152. Happy to break down the PR into smaller chunks if needed!
https://hexdocs.pm/credo/Credo.Check.Readability.PredicateFunctionNames.html and this is the new Credo check that was breaking the builds after upgrading to 1.7.4
Hey @iarekk - thank you so much for this QoL PR, really appreciate the assistance!
This is a pretty sizable update, so your dedication to fixing all the credo warnings is really awesome - normally I'd prefer to break this PR up a bit (one for the GitHub Action change, one for the credo bump), but I think it makes sense in this case plus the work is already done and all working together harmoniously / passing checks. So we're good to go here!
Thank you @houllette! I'm very happy to help the project – and will definitely keep the PRs smaller nex time 😄
Several changes:
elixir 1.16.x / OTP 26.2
to the matrix.credo
to1.7.4
. Reason: Credo1.7.0
issues a huge number of warnings about itself when compiled with Elixir 1.6.x, update to 1.7.4 fixes it. Some discussion in the Credo repo here: https://github.com/rrrene/credo/pull/1085The change is to rename functions such as
is_router?
torouter?