Add TST as valid value for “Single Nucleus Buffer"

clarisse-lau commented 10 months ago

Information

Proposed change:

Add TST as option for required attribute Single Nucleus Buffer Current valid values are : NIB, 10x, Omni

Dicussion link:

Email from Allison Frangieh (DFCI) Oct 3, 2023:

We are working on submitting the ScATAC-seqLevel1 spreadsheet on the DCA for our snRNAseq TNP data. We’re having trouble with one column:

“Single Nucleus Buffer”- this is a required field and “unknown” or “not applicable” (in any variation) is not accepted. The valid values are 10x, NIB, or Omni, but none are applicable to the protocol we used (i.e. TST buffer from Slyper et al. paper). I think we are unable to submit until this error is resolved.

How important is this feature?

🌋 Important - it's a blocker and can't do work without it

When will use cases depending on this become relevant?

Short-term - 2-4 weeks

Implementation checklist

[ ] Branch created
[ ] HTAN.model.csv editied and pushed
[ ] HTAN.model.jsonld validated and created by Github action
[ ] PR opened
[ ] PR approved
[ ] PR merged into main
[ ] New Component added to ncihtan/HTAN-data-curator (if required)
[ ] DCA update requested
[ ] DCA updated

aclayton555 commented 10 months ago

@elv-sb can tackle this during this sprint! Thanks!

clarisse-lau commented 10 months ago

Hi @aclayton555 @elv-sb @adamjtaylor !

Our collaborator is asking for an estimated timeline for when this will be available in DCA. Will this update be included in the next data model release (end of the month, I presume)?

adamjtaylor commented 10 months ago

@clarisse-lau asked that we escalate during our CRDC call so I have implemented and will push through

clarisse-lau commented 10 months ago

Thanks @adamjtaylor !

adamjtaylor commented 10 months ago

@clarisse-lau this should now be live in production. 🚀

clarisse-lau commented 10 months ago

Have notified the user. Thank you!

ncihtan / data-models