search

ncssar / radiolog

SAR radio log program
Other
15 stars 3 forks source link

reset team timeout timer on any incoming non-mic-bump call, even if no entry is saved #750

Closed caver456 closed 1 month ago

caver456 commented 3 months ago

Probably not for bumps; really we only want to reset if there is legible traffic, even if not to IC; maybe only if the call is more than two seconds? Or maybe just if it's not mic-bump-filtered?

caver456 commented 1 month ago

Right now, in updateTeamTimers, secondsSinceContact (a.k.a. teamTimersDict value for that callsign) doesn't reset until an entry is accepted. So, traffic from the team to a different team, when the operator intentionally cancels the NEW, does NOT reset secondsSinceContact.

What's the right way to go to protect team safety? 1) Continue as is, or, 2) change so that any non-bump call resets secondsSinceContact even if no entry is accepted? Seems like the only time 2) would lead to failure-to-timeout is if there is a transmission of silence that's longer than a mic bump.

Making a decision: let's go with 2). There's danger in 1) also, since after a while the team may intentionally go on timeout during conversation with another team, and the operator may just get numb to the flashing red. With 2), the flashing red is more attention-getting because there's less chance that flashing red would be the 'normal expected state since they haven't called IC'.

Also, keep in mind that teamTimersDict keeps track of seconds since contact per callsign, not per device. So, a call from any device on a team with multiple devices for the same callsign will reset that callsign's timer. This is fine.