search

ndarilek / tts-rs

115 stars 25 forks source link

Implementing Debug trait and other common traits #17

Closed saona-raimundo closed 2 years ago

saona-raimundo commented 2 years ago

Hi there!

Thank you for the crate!

I wanted to ask if we could implement the Debug trait... and other common traits, as advised by the Rust API guidelines.

I am happy to do some PRs if you want to.

ndarilek commented 2 years ago

The challenge is that things need to work on multiple platforms, and IIRC Debug and others are challenging to make work universally.

Feel free to contribute PRs if you like, but note that any which fail to build on all platforms can't be accepted.

Thanks!

saona-raimundo commented 2 years ago

Thank you!

I did not know how to test it on all platforms, should I install the toolchains and build the crate? I did not see any automatic test in Github.

ndarilek commented 2 years ago

There is the GitHub CI workflow that builds for all platforms. I've just approved the workflow run, so we'll see how it goes.

Thanks!

saona-raimundo commented 2 years ago

Thank you! I fixed there some tests :)