search

ndmitchell / extra

Extra Haskell functions
Other
94 stars 37 forks source link

Build failures with GHC >= 9 in v1.5 to v1.7.6 #90

Closed sjakobi closed 2 years ago

sjakobi commented 2 years ago 
src/System/IO/Extra.hs:76:41: error:
    Ambiguous occurrence ‘hGetContents'’
    It could refer to
       either ‘System.IO.hGetContents'’,
              imported from ‘System.IO’ at src/System/IO/Extra.hs:23:1-16
              (and originally defined in ‘GHC.IO.Handle.Text’)
           or ‘System.IO.Extra.hGetContents'’,
              defined at src/System/IO/Extra.hs:65:1
   |
76 | readFile' file = withFile file ReadMode hGetContents'
   |                                         ^^^^^^^^^^^^^

src/System/IO/Extra.hs:80:79: error:
    Ambiguous occurrence ‘hGetContents'’
    It could refer to
       either ‘System.IO.hGetContents'’,
              imported from ‘System.IO’ at src/System/IO/Extra.hs:23:1-16
              (and originally defined in ‘GHC.IO.Handle.Text’)
           or ‘System.IO.Extra.hGetContents'’,
              defined at src/System/IO/Extra.hs:65:1
   |
80 | readFileEncoding' e file = withFile file ReadMode $ \h -> hSetEncoding h e >> hGetContents' h
   |                                                                               ^^^^^^^^^^^^^

src/System/IO/Extra.hs:88:53: error:
    Ambiguous occurrence ‘hGetContents'’
    It could refer to
       either ‘System.IO.hGetContents'’,
              imported from ‘System.IO’ at src/System/IO/Extra.hs:23:1-16
              (and originally defined in ‘GHC.IO.Handle.Text’)
           or ‘System.IO.Extra.hGetContents'’,
              defined at src/System/IO/Extra.hs:65:1
   |
88 | readFileBinary' file = withBinaryFile file ReadMode hGetContents'
   |                                                     ^^^^^^^^^^^^^

src/System/IO/Extra.hs:121:16: error:
    Ambiguous occurrence ‘readFile'’
    It could refer to
       either ‘System.IO.readFile'’,
              imported from ‘System.IO’ at src/System/IO/Extra.hs:23:1-16
           or ‘System.IO.Extra.readFile'’,
              defined at src/System/IO/Extra.hs:76:1
    |
121 |         out <- readFile' file
    |                ^^^^^^^^^
cabal: Failed to build extra-1.5. See the build log above for details.

As a Hackage trustee, I have created revisions for these versions that should prevent users from getting these errors. See e.g. https://hackage.haskell.org/package/extra-1.7.6/revisions/.

sjakobi commented 2 years ago

This issue is just FYI.

ndmitchell commented 2 years ago

Thanks! Happy if someone wants to go and roll out more revisions.