search

ndmitchell / hlint

Haskell source code suggestions
Other
1.48k stars 195 forks source link

ignore files match ignore-glob even if it is explicit provided under arg like `--git` in cmd #1554

Closed soulomoon closed 10 months ago

soulomoon commented 10 months ago

It should fix problems such as with "--git:, would not ignore files matching the ignore-glob Should fix #1552

soulomoon commented 10 months ago

Should ignore-glob filter out all files even if they are provided explicit such as with arg --git At least with --git, we should filter out files matching ignore-glob, for example, the test data files with .hs suffix. we have a use case in haskell-language-server https://github.com/haskell/haskell-language-server/pull/3901#issue-2041279577

ndmitchell commented 10 months ago

Thanks! Great fix. Definitely should combine them since they do work together quite sensibly.