ndmitchell / neil

General tools for Neil
Other
38 stars 16 forks source link

Allow specifying any GitHub user and commit in travis.sh #40

Closed tomjaguarpaw closed 6 years ago

tomjaguarpaw commented 6 years ago

I would like to be able to use neil from my own GitHub repository. Furthermore I would like my packages to be able to specify a specific commit or branch to test with, firstly so that they don't have to be updated in lockstep with master and secondly to allow myself to test different versions of neil.

checkTravis expects a script stanza like this

- curl -sL https://raw.github.com/tomjaguarpaw/neil/<commit>/travis.sh | sh -s tomjaguarpaw <commit>

and it just checks that GitHub user name and commit match on both sides of the pipe.

tomjaguarpaw commented 6 years ago

To preserve the old behaviour change your packages' travis.yml scripts from

- curl -sL https://raw.github.com/ndmitchell/neil/master/travis.sh | sh

to

- curl -sL https://raw.github.com/ndmitchell/neil/master/travis.sh | sh -s ndmitchell master
ndmitchell commented 6 years ago

I'd be a fan of defaulting to ndmitchell and master, but allowing this customisation - which seems entirely reasonable.

tomjaguarpaw commented 6 years ago

OK, my latest version defaults to ndmitchell and master so your existing travis.ymls don't need to change.

ndmitchell commented 6 years ago

Thanks!

ndmitchell commented 6 years ago

I just followed up with a few cleanups to fix older GHC's and not require -s if you have no arguments.

tomjaguarpaw commented 6 years ago

Yes, good idea!