search

ndom91 / rose-pine-hyprcursor

BreezeX RosePine for Hyprcursor
GNU General Public License v3.0
43 stars 1 forks source link

Consider PRing to main Rosé Pine cursors repo #3

Open ThatOneCalculator opened 5 months ago

ThatOneCalculator commented 5 months ago

Hello! I'm the maintainer of the Rosé Pine cursors repo, and I'd love to bundle these with the main cursor builds! If not, I'd still love to get this repo into the Rosé Pine org so we can feature it on the website :)

ndom91 commented 5 months ago

Hey thanks for stopping by haha. Yeah so I'd be open to PR-ing it back into the main rose-pine cursor. How do you prefer we proceed?

Currenlty I only have dark-mode enabled here. I needed to take your "negative" svg's and apply the fg/bg colors for dark mode that are listed in the build process to generate ready-to-use dark mode SVG's (didn't want to use raster versions).

Anyway, I can run them through a find/replace and generate the light-mode ones as well

ThatOneCalculator commented 5 months ago

Putting them in a hyprcursors folder in the main repo should be fine, and updating the readme to let people know there's a hyprcursor variant

vaxerski commented 5 months ago

maybe fixing the theme so that it actually works could be a good idea before that. Doesn't look like it was generated by util, as all compressed cursors are invalid.

ndom91 commented 5 months ago

Yeah someone else had problems with it on discord too 🤔

It wasn't generated with the util, but the cursors are just the meta files and svgs, I copied the structure and settings from an example you uploaded. Did you see what exactly was wrong with them?

vaxerski commented 5 months ago

yes, you didn't copy the structure.

image

left, rose pine, right, a theme made by the util

ndom91 commented 5 months ago

Ahh I didnt realize it included the dir too. Okay easy fix, thanks.

ndom91 commented 5 months ago

Alright, I put up a v0.3.2 (release with zip) and updated the flake + aur. Let me know if you still have issues.

What's another way to really confirm this works? I've got the env var set, a manual hyprctl setcursor returns ok and the flake puts the seemingly correct archives now to ~/.nix-profile/share/icons/rose-pine-hyprcursor/hyprcursor/xterm.hlc (for example).

Archive contents:

image

However, I can't see any change when, for exmaple, executing: hyprctl setcursor rose-pine-hyprcursor 32, 64, 100 or any other int :thinking:

troylusty commented 5 months ago

This is now working as intended for me after the update to v0.3.2 installed via the AUR. I am even able to change its size using the command hyprctl setcursor rose-pine-hyprcursor 32 for example.

vaxerski commented 5 months ago

What's another way to really confirm this works? I've got the env var set, a manual hyprctl setcursor returns ok and the flake puts the seemingly correct archives now to ~/.nix-profile/share/icons/rose-pine-hyprcursor/hyprcursor/xterm.hlc (for example).

use hyprcursor-test from the hyprcursor repo. If you have multiple themes, you can force a theme by replacing nullptr in the constructor with "myTheme"