ndonfris / fish-lsp

LSP implementation for the fish shell langauge 🐠
https://fish-lsp.dev
MIT License
97 stars 6 forks source link

feat: logging behaviour opt-in by "$fish_lsp_logsfile" #47

Closed ndonfris closed 4 months ago

ndonfris commented 4 months ago

Disable the requirement for the fish-lsp to forward logging to a file.

This will remove edge cases from distribution packages like NixOS, where the installation can't create a file with write permissions, or has different directory structure than our default repo expects


Initial Discussion Below:

I'm going to try to make the default logging behavior for the server opt-in by defining the variable fish_lsp_logfile and removing the fish-lsp start --enable/--disable logging key. This would avoid the opt-out workarounds the project currently enforces. When logging is not enabled to a file, it will still be available from most language clients because of connection.console.

Originally posted by @ndonfris in https://github.com/ndonfris/fish-lsp/issues/46#issuecomment-2251101186