v1.0.8 doesn't include log file changes

ndonfris / fish-lsp

LSP implementation for the fish shell langauge 🐠

https://fish-lsp.dev

MIT License

97 stars 6 forks source link

v1.0.8 doesn't include log file changes #51

Closed petertriho closed 4 months ago

petertriho commented 4 months ago

Describe the bug Looks like v1.0.8 was tagged incorrectly. It doesn't include the log file changes.

ndonfris commented 4 months ago

Sorry about that! The tag has been updated on github.

I will republish v1.0.8 on npm, once the time limit is removed (within 24hrs).

ndonfris commented 4 months ago

Actually, here is a patched version v1.0.8-1:

Please let me know if there are any other issues!

petertriho commented 4 months ago

Thanks, don't need to wait for npm since the nix builds pull from github.

Have the PR ready, just having some issues with the pr checks. Refactored the nix package to use mkDerivation + yarnConfigHook/yarnBuildHook instead of the old mkYarnPackage way. I also don't need the fish_wasm_file changes anymore but doesn't hurt just leaving it there. https://github.com/NixOS/nixpkgs/pull/330996