search

ndy2 / mkdocs-obsidian-support-plugin

A MkDocs plugin that supports obsidian to mkdocs convert
https://ndy2.github.io/mkdocs-obsidian-support-plugin/
MIT License
14 stars 4 forks source link

Missing import override #41

Closed SebastianErfort closed 6 months ago

SebastianErfort commented 6 months ago

Hi there,

in 6586243a you introduced

from overrides import override
# and
from overrides import final

These imports give me errors as I don't have the module(s) to be loaded.

Can you please tell me where to find it or make it part of the package?

Thank you and cheers, Sebastian

ndy2 commented 6 months ago

Hi.

It's in requirements.txt. And it is https://github.com/mkorpela/overrides <- this libary.

It simply checks the overrided method has correct signature from its parent in when its loaded.

You can install it by pip install overrides or install or requriements by pip install -r requirements.txt .

SebastianErfort commented 6 months ago

That wasn't so hard to find :man_facepalming: Thank you

ndy2 commented 6 months ago

However, sorry for bad commit history. 😅