search

ne0fite / GigKeeper

GNU General Public License v3.0
1 stars 0 forks source link

Koa Refactor #78

Closed ne0fite closed 7 years ago

ne0fite commented 7 years ago

Refactored API backend to Koa and ripped out Hapi.

As of this commit, the backend no longer serves static files. You need to install npm serve and serve the www directory.

** Be sure to set your app.baseUrl config to use the port that serve is using.

zero-degrees commented 7 years ago

The application works fine in my development environment, however...

The backend is throwing koa deprecation warnings in the console on startup.

I think functions of the config's "app" and "api" members have become confused. Additionally, the "baseUrl" and "base" members seem like things that we could/should build inside the app from whatever protocol, hostname, and port were supplied.

The Koa team states on their official site that async is required in the first sentence of the installation section, and their examples all use async. The removal of the asyncs worries me, though I don't know how or if the application will fail under a real world load. If the move was just to satisfy eslint, maybe we should look at replacing it with jshint, jslint, or something else.