search

nealmckee / penumbra

Penumbra Color Theme
MIT License
1.4k stars 31 forks source link

Color for comments is difficult to read on some displays / view angles #7

Open jackrobbins1 opened 2 years ago

jackrobbins1 commented 2 years ago

The gray color used for comments in both the light and dark versions of this theme is difficult to read against the background color. This issue may be more noticeable on monitors with low contrast ratios (I'm using an HP 27Q monitor).

The gray color for comments is easier to read on better performing displays like the one built in to my MacBook Air. However, I think some subtle tweaking of this color or adding more theme options with an alternate comment color would solve this problem.

nealmckee commented 2 years ago

When designing the colours, I was targeting a decently well calibrated, relatively recent display with full sRGB coverage. If this is not what you‘re working with, the comment colour will likely not be the only issue you run into.

Do you feel like it‘s fine on the MacBookAir?

The high(est) contrast version should be compensating for this already, do you have the same issue using the contrast++ version? (Unfortunately the design constraints do not allow for a higher contrast light version)