search

near / nearcore

Reference client for NEAR Protocol
https://near.org
GNU General Public License v3.0
2.33k stars 632 forks source link

Gracefully handle RuntimeError in NightshadeRuntime #2152

Open evgenykuzyakov opened 4 years ago

evgenykuzyakov commented 4 years ago

The following lines have panics for some errors: https://github.com/nearprotocol/nearcore/blob/9ed24269598ac1f1e8e33319c80c17faac51ba93/near/src/runtime.rs#L304-L312

We need to handle them gracefully and create challenges whenever possible.

MaksymZavershynskyi commented 4 years ago

Creating challenges seems like a large work item, assigning 13 days for it.

bowenwang1996 commented 4 years ago

@nearmax we are removing challenges from mainnet launch. Changing it to post-mainnet.

evgenykuzyakov commented 4 years ago

Who want to take this? @bowenwang1996 I'm not familiar with chain enough to know how to handle it properly

MaksymZavershynskyi commented 4 years ago

Assigning it to @SkidanovAlex and moving it to Ice Box.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.