Remove default s2i content and start the repl instead.

mcollina commented 6 years ago

$ docker run nearform/alpine3-s2i-nodejs:9
This is a Source2Image base for Nodejs:
To use it, install S2I: https://github.com/openshift/source-to-image

Sample invocation:
s2i build https://github.com/nearform/nodejs-distribution --context-dir=contrib/demo nearform/alpine3.7.0-s2i-nodejs:8 demo-app-alpine3.7.0

You can then run the resulting image via:
docker run -p 8080:8080 demo-app-alpine3.7.0

If we compare this with the stock node image:

$ docker run -ti node
> process.versions
{ http_parser: '2.7.0',
  node: '9.4.0',
  v8: '6.2.414.46-node.17',
  uv: '1.18.0',
  zlib: '1.2.11',
  ares: '1.13.0',
  modules: '59',
  nghttp2: '1.29.0',
  openssl: '1.0.2n',
  icu: '60.1',
  unicode: '10.0',
  cldr: '32.0',
  tz: '2017c' }
>

I think they should behave identically.

conoro commented 6 years ago

@mcollina Agree for Alpine but not for RHEL or CentOS S2I. We have made it behave like other S2I images on OpenShift i.e. tell people how to use it.

mcollina commented 6 years ago

l think it should be picked based on the destination: docker hub or red hat catalog.

conoro commented 6 years ago

👍

Elexy commented 6 years ago

+1

Elexy commented 6 years ago

https://trello.com/c/ZWGXzoX7

nearform / nodejs-distribution

Remove default s2i content and start the repl instead. #4