[ENH] - Include "--attempt-fixes" flag from Nebari upgrade CLI in upgrade steps logic - Githubissues

nebari-dev / nebari

🪴 Nebari - your open source data science platform

https://nebari.dev

BSD 3-Clause "New" or "Revised" License

283 stars 93 forks source link

[ENH] - Include "--attempt-fixes" flag from Nebari upgrade CLI in upgrade steps logic #2839

Open smokestacklightnin opened 2 weeks ago

smokestacklightnin commented 2 weeks ago

Reference Issues or PRs

This resloves #2761 by passing the attempt_fixes variable from the command line option to the upgrade methods.

What does this implement/fix?

Put a x in the boxes that apply

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds a feature)
[ ] Breaking change (fix or feature that would cause existing features not to work as expected)
[ ] Documentation Update
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[ ] Other (please describe):

Testing

[ ] Did you test the pull request locally?
[ ] Did you add new tests?

How to test this PR?

Run nebari upgrade --attempt-fixes and verify that the upgrade is successful without prompts from the user.

Any other comments?

dcmcand commented 2 weeks ago

This should probably be a draft PR if you still have questions about the implementation

marcelovilla commented 2 weeks ago

@smokestacklightnin can you also make sure the tests are passing?