Fix checking prefix for configuration name

nebula-plugins / gradle-lint-plugin

A pluggable and configurable linter tool for identifying and reporting on patterns of misuse or deprecations in Gradle scripts.

Apache License 2.0

771 stars 89 forks source link

Fix checking prefix for configuration name #354

Closed chali closed 3 years ago

chali commented 3 years ago

This PR replaces #352 with a different solution for failing tests.

rhoughton-pivot commented 3 years ago

This is the same functional fix as https://github.com/nebula-plugins/gradle-lint-plugin/pull/352, except you fixed the deprecation instead of turning off warnings about it (I'm not up-to-date on the newest Gradle version, or I'd have fixed it, too.) Not taking my PR and making your own feels like a slap-down. Did I do something wrong in trying to contribute?

chali commented 3 years ago

@rhoughton-pivot sorry no slap down was intended. Ignoring the warning would work but eventually, we would have to fix it anyway. Since I was looking into failed tests and I had all the changes done anyway it felt faster to create a new PR.