necauqua / chiseled-me

A mod that can make you small to sneak into places
MIT License
15 stars 11 forks source link

Camera/bbox misbehavior with Idō Mod #70

Closed Alexandqr closed 3 years ago

Alexandqr commented 3 years ago

When using Ido's features with this mod installed (such as sneaking, as it changes your z size from 0.85 to 0.75, crawling, like in 1.13+, and swimming), your camera will shake or widen. With larger (or smaller, I couldn't check because Minecraft crashed) sizes, your hitbox also grows to a size Minecraft can't handle, making your game freeze.

Steps to reproduce the behavior:

  1. Install both mods
  2. To see basic misbehavior, start sneaking. For others, you have to change your size, or swim.

What should happen is that Ido's bbox changes should be similar to the elytra, as it only changes the z size of the hitbox, not the x or y size.

I'm not sure if this is going to be fixed, as both mods change the bbox (and most mods that change bboxes don't play well), but I thought I might as well say this has an incompatibility, and in hope that maybe something could be done. And yes, I literally just made this account so I could post this.

necauqua commented 3 years ago

No updates of any sorts atm, just writing to show that I noticed and yes, thanks for sharing the incompatibility.

From how you described this I think there might be ways to work around the issue - at least partially, to make it not break completely, just needs testing/checking etc.

Alexandqr commented 3 years ago

I see, hopefully this can be fixed after you finish the next update. Keep up the good work!

necauqua commented 3 years ago

Ok I am actually going through issues in preparation for finally releasing that crazy good discord beta, and like, what did you expect from the mod that changes the player hitbox as well, huh

Still will try to fix it, actually not a lot of issues for 1.12 left

necauqua commented 3 years ago

Ok right now latest beta mostly works nicely with the mod, zero camera issues (especially because I explicitly patched broken camera resize animation that happen with randompatches mod), sneaking and swimming (even when resized) work fine and crawling works fine on normal size, the only weird issues (at least your hitbox is the crawling little cube) arise when you are small and move in 1x1x1 holes, and sometimes hitbox is zero.

For now I guess this is wontfix, camera issues most likely were fixed accidentally with other fixes and the Mixin rewrite and everything. Feel free to open another issue (or maybe even reopen this one) if you have game-breaking (like unusable camera that you had it seems) issues.