feat: check img uri is in cache reliably

necolas / react-native-web

Cross-platform React UI packages

https://necolas.github.io/react-native-web

MIT License

21.69k stars 1.79k forks source link

feat: check img uri is in cache reliably #2709

Open dominictb opened 3 months ago

dominictb commented 3 months ago

Fix #2708

necolas commented 1 month ago

How is this issue supposed to be reproduced within the RNfWeb codebase, so the fix can be tested?

dominictb commented 3 weeks ago

@necolas sorry for late reply, but the original issue in Expensify is fixed in another way. Even though this analysis is correct and this PR is a nice improvement, however it doesn't make any difference in terms of UI/UX, and it also breaks the component in SSR. Hence, I think it might not worth merging this PR, but I'll discuss with the internal team to see what's the best decision on this.