search

neeckeloo / monolog-module

Monolog integration into Laminas
MIT License
8 stars 3 forks source link

Fix GelfHandlerFactory to be compatible with ServiceManager v3 #4

Closed arjanvdbos closed 8 years ago

arjanvdbos commented 8 years ago

The GelfHandlerFactory is currently not compatible with version 3 of the ServiceManager because the options array in the constructor is mandatory. In v3 the options are passed via the __invoke method.

This fix made the constructor options optional (to be compatible with v2) and also allows the options to be passed via the __invoke method (v3). Afaik no BC breaks.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+1.09%) to 89.552% when pulling f0de3393828243fdd000e09f915e9c858a19e2f4 on arjanvdbos:fix-deprecated-factory-constructor into 237c9ac4eed24c47c5fc55d990c81ef8e4a3919a on neeckeloo:master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+1.09%) to 89.552% when pulling f0de3393828243fdd000e09f915e9c858a19e2f4 on arjanvdbos:fix-deprecated-factory-constructor into 237c9ac4eed24c47c5fc55d990c81ef8e4a3919a on neeckeloo:master.

neeckeloo commented 8 years ago

Thanks.