negativetwelve / heroku-buildpack-subdir

Deploy apps from subdirectories to Heroku
77 stars 61 forks source link

Usage with heroku/heroku-buildpack-static #16

Open cyrilchapon opened 5 years ago

cyrilchapon commented 5 years ago

Heroku backs a fantastic buildpack that is a thin wrapper around nginx, called heroku-buildpack-static.

Though, it's currently incompatible with heroku-buildpack-subdir because the former specifies some absolute paths inside one of it's template files.

I think it would be very nice to make those 2 buildpacks play well with each-other because heroku-buildpack-subdir is a great way to cleanly install, release and run multiple apps in subdirs; and heroku-buildpack-static on its side is a great way to serve / proxy to apps.

Those 2 together make a great starting point to make multi-apps Heroku apps, with a reverse-proxy in front of it, and a clean and reliable stack.

This is issue is not really really related to heroku-buildpack-subdir, but it's rather a way to ask your help here to make a clever and quick PR to heroku-buildpack-static to make both play well together.

I mirrored the issue there

Thanks for your help, and this great buildpack 🙂