search

neighbour-hoods / nh-launcher

Creating a group coherence with holochain apps
Other
4 stars 3 forks source link

Make Nh-Select take a slot for options #127

Open nick-stebbings opened 10 months ago

adaburrows commented 8 months ago

@nick-stebbings What is the status of this? I know we discussed it on a call, but I don't remember if it was easy enough to implement then and there or if it got burried by other work.

nick-stebbings commented 8 months ago

@nick-stebbings What is the status of this? I know we discussed it on a call, but I don't remember if it was easy enough to implement then and there or if it got burried by other work.

I have made several updates to the select component since then. But I am not sure how it will work with options in terms of a) keeping the component styled consistently, and b) interacting with NH Form:

a) Currently it takes an option value (text) with a possible base64 image and then formats them accordingly. b) Having had another look I am not sure how we can have slots for options here without breaking it. Partly due to the fact that the NhForm api needs a select with a value prop and that is something that the array of options being configure with objects is currently enabling. How would we pull a value from a slotted element that could be anything?

nick-stebbings commented 7 months ago

@adaburrows When you have time perhaps we could discuss whether this issue makes sense given the comment above. I can go ahead if I know how the options slot can be used without breaking styling.