search

nektra / Deviare2

Deviare API Hook
http://www.nektra.com/products/deviare-api-hook-windows/
Other
448 stars 127 forks source link

Exit stack parsing loop in a different way #31

Closed bzzzil closed 6 years ago

bzzzil commented 7 years ago

Hi!

Not sure about details, but why not to check for null-pointer before dereference here? Previous approach works, but I receive huge amount of exceptions in debug output. Very inconvenient.

mxmauro commented 7 years ago

The try/except block will catch NULL and invalid pointers when the memory is accessed.

bzzzil commented 7 years ago

Yes, it is catching successfully, here everything fine :) But such exceptions are still reported in debug output window in Visual Studio. So when there are many there exceptions, hard to use debug output for own proposes. I've made this local fix just to avoid such spam.

mxmauro commented 6 years ago

Hi @bzzzil after several months I see this. Sorry for the long delay. Seems the commit tree is broken so I'll fix it and add your change. Thank you.

bzzzil commented 6 years ago

@mxmauro, thx!

As I wrote before I'm pretty happy with my local changes and it does resolve my problem. Should it be included into main repo - this is up to you.