fix: incorrect directory used for updated swagger-ui

nelmio / NelmioApiDocBundle

Generates documentation for your REST API from annotations

MIT License

2.23k stars 836 forks source link

fix: incorrect directory used for updated swagger-ui #2379

Closed DjordyKoert closed 3 weeks ago

DjordyKoert commented 3 weeks ago

Description

Fixes incorrect directory used for updated swagger-ui files introduced in https://github.com/nelmio/NelmioApiDocBundle/pull/2378

What type of PR is this? (check all applicable)

[x] Bug Fix
[ ] Feature
[ ] Refactor
[ ] Deprecation
[ ] Breaking Change
[ ] Documentation Update
[ ] CI

Checklist

[ ] I have made corresponding changes to the documentation (docs/)
[ ] I have made corresponding changes to the changelog (CHANGELOG.md)

s3tezsky commented 3 weeks ago

Hi again!

I have just noticed there was some updates necessery after merging previous PR (#2378)

The wrong path of original fix was casued by update script: https://github.com/nelmio/NelmioApiDocBundle/blob/9d74fa9874b9f9b13b2fa4f6eb38082c2405c33b/update-js.sh#L10

Is the script correct? or should it be updated too?

DjordyKoert commented 3 weeks ago

Hi again!

I have just noticed there was some updates necessery after merging previous PR (#2378)

The wrong path of original fix was casued by update script:

https://github.com/nelmio/NelmioApiDocBundle/blob/9d74fa9874b9f9b13b2fa4f6eb38082c2405c33b/update-js.sh#L10

Is the script correct? or should it be updated too?

The script is incorrect :/