search

nelsonjchen / speedtest-rs

(Unmaintained) speedtest-cli in Rust.
Apache License 2.0
164 stars 17 forks source link

Improve offline error messages #142

Open FireIsGood opened 9 months ago

FireIsGood commented 9 months ago

The current error message while offline is a raw reqwest error. I think it would be nice to have a custom error message in place of that.

Example:

Retrieving speedtest.net configuration...
Error: Reqwest(reqwest::Error { kind: Request, url: Url { scheme: "http", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("www.speedtest.net")), port: None, path: "/speedtest-config.php", query: None, fragment: None }, source: hyper::Error(Connect, ConnectError("dns error", Custom { kind: Uncategorized, error: "failed to lookup address information: Name or service not known" })) })

An error that just has the last part would be nice. Perhaps a framework like color eyre?

nelsonjchen commented 9 months ago

This project isn't exactly active but I'll take a pull request.

On Mon, Feb 5, 2024, 11:02 AM FireIsGood @.***> wrote:

The current error message while offline is a raw reqwest error. I think it would be nice to have a custom error message in place of that.

Example:

Retrieving speedtest.net configuration... Error: Reqwest(reqwest::Error { kind: Request, url: Url { scheme: "http", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("www.speedtest.net")), port: None, path: "/speedtest-config.php", query: None, fragment: None }, source: hyper::Error(Connect, ConnectError("dns error", Custom { kind: Uncategorized, error: "failed to lookup address information: Name or service not known" })) })

An error that just has the last part would be nice. Perhaps a framework like color eyre?

— Reply to this email directly, view it on GitHub https://github.com/nelsonjchen/speedtest-rs/issues/142, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAABJ4ZZYIRVOWHJQ3LVAPTYSEUFTAVCNFSM6AAAAABC2VQ732VHI2DSMVQWIX3LMV43ASLTON2WKOZSGEYTSMRWGY3DAOA . You are receiving this because you are subscribed to this thread.Message ID: @.***>