search

nemccarthy / stash-pullrequest-builder-plugin

A Jenkins plugin for Building Stash Pull Requests
https://wiki.jenkins-ci.org/display/JENKINS/Stash+pullrequest+builder+plugin
Other
64 stars 130 forks source link

SocketTimeout causes rebuilding a PR multiple times #102

Closed MartinMReed closed 4 years ago

MartinMReed commented 7 years ago

Issue #101: SocketTimeout causes rebuilding a PR multiple times. If a SocketTimeoutException is thrown while reading any of the comment responses, it will be consumed and an empty list will be returned for the comments. The empty list then triggers the build to run again because the plugin thinks no previous attempts were made.

nickbroon commented 7 years ago

:+1:

nemccarthy commented 7 years ago

Could we fix conflicts and ill merge this in thanks

MartinMReed commented 7 years ago

@nemccarthy Done.

Macarse commented 7 years ago

@nemccarthy can you push an update with this?

batmat commented 5 years ago

Unmaintained repo, unrelated to the Jenkins Project FYI. See https://github.com/nemccarthy/stash-pullrequest-builder-plugin/issues/158