Add option to disable all build comments to Stash

nemccarthy / stash-pullrequest-builder-plugin

A Jenkins plugin for Building Stash Pull Requests

https://wiki.jenkins-ci.org/display/JENKINS/Stash+pullrequest+builder+plugin

Other

64 stars 130 forks source link

Add option to disable all build comments to Stash #134

Closed Nuh closed 5 years ago

Nuh commented 6 years ago

In some cases, build comments mislead the PR reviewer on BitBucket. So its nice to have a disable all comments to clarify discussion.

Example case: Old-style pipelines based on freestyles jobs and using pipeline view plugin. Making a parallel build needs create small steps as different jobs to run, then build status of triggered, first, job does not matches to pipeline build status.

oyvindlr commented 6 years ago

After I added these commits, jenkins will rebuild every time. I see there is a commit with the message "Fix infinity building PR when comment disabled" but that fix doesn't seem to work for me.

Nuh commented 6 years ago

Are you sure? My patch based on adding information of built PR in "Action" - It works only for a new builds, so probably it rebuild all open PRs once. @oyvindlr, could you attach some logs? Plugin log on INFO level all process between requests to BB and execute a job.